evin/secretary
3
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Removing some properties cause Python Is Not Java

Browse source 
Getters and setters are evil when all you need is simple attribute
access

http://dirtsimple.org/2004/12/python-is-not-java.html
This commit is contained in:
Andrés Reyes Monge 2013-07-31 14:53:16 -06:00
parent c8c4d828bc
commit e5c0e94d75
1 changed files with 5 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

23
__init__.py
View file

@ -74,7 +74,7 @@ def pad_string(value, length=5):
return value.zfill(length) return value.zfill(length)
class Render(): class Render(object):
""" """
Main engine to convert and ODT document into a jinja Main engine to convert and ODT document into a jinja
compatible template. Render provides an enviroment compatible template. Render provides an enviroment
@ -98,19 +98,6 @@ class Render():
_mimetype = '' _mimetype = ''
@property
def environment(self):
return self._environment
@environment.setter
def enviroment(self, value):
self._environment = value
@property
def template(self):
return self._template
@template.setter
def template(self, value):
self._template = value
# def __init__(self, xml_doc, template_args): # def __init__(self, xml_doc, template_args):
@ -123,8 +110,8 @@ class Render():
""" """
self.template = template self.template = template
self._environment = Environment(undefined=UndefinedSilently, autoescape=True) self.environment = Environment(undefined=UndefinedSilently, autoescape=True)
self._environment.filters['pad'] = pad_string self.environment.filters['pad'] = pad_string
def unpack_template(self): def unpack_template(self):
@ -196,7 +183,7 @@ class Render():
# Render content.xml # Render content.xml
self.prepare_template_tags(self.content) self.prepare_template_tags(self.content)
template = self._environment.from_string(self.content.toxml()) template = self.environment.from_string(self.content.toxml())
result = template.render(**kwargs) result = template.render(**kwargs)
result = result.replace('\n', '<text:line-break/>') result = result.replace('\n', '<text:line-break/>')
self.content = parseString(result.encode('ascii', 'xmlcharrefreplace')) self.content = parseString(result.encode('ascii', 'xmlcharrefreplace'))
@ -204,7 +191,7 @@ class Render():
# Render style.xml # Render style.xml
self.prepare_template_tags(self.styles) self.prepare_template_tags(self.styles)
template = self._environment.from_string(self.styles.toxml()) template = self.environment.from_string(self.styles.toxml())
result = template.render(**kwargs) result = template.render(**kwargs)
result = result.replace('\n', '<text:line-break/>') result = result.replace('\n', '<text:line-break/>')
self.styles = parseString(result.encode('ascii', 'xmlcharrefreplace')) self.styles = parseString(result.encode('ascii', 'xmlcharrefreplace'))