evin/ms-nfs41-client
3
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

name cache: skip rename with same src and target

Browse source 
fileio tests 214,215 does lots of renames with the same source and target filename.  nfs41_name_cache_rename() would operate on the same pointer for both src and existing, and accidentally turn both into a negative entry

Signed-off-by: Casey Bodley <cbodley@citi.umich.edu>
This commit is contained in:
Casey Bodley 2012-04-25 15:03:46 -04:00 • committed by unknown
parent beb33855e0
commit 787202cb9d
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
daemon/name_cache.c
View file

@ -1184,6 +1184,8 @@ int nfs41_name_cache_rename(
struct name_cache_entry *existing; struct name_cache_entry *existing;
existing = name_cache_search(cache, dst_parent, dst_name); existing = name_cache_search(cache, dst_parent, dst_name);
if (existing) { if (existing) {
if (existing == src)
goto out_unlock;
/* remove the existing entry, but don't unlink it yet; /* remove the existing entry, but don't unlink it yet;
* we may reuse it for a negative entry */ * we may reuse it for a negative entry */
name_cache_remove(existing, dst_parent); name_cache_remove(existing, dst_parent);