evin/ms-nfs41-client
3
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

[driver] invalidate data cache on data access reopens

Browse source 
test cases 208, 219, 221 of fileio were failing if rdbss caching was
turned on. the reason was, on reopen of a file, rdbss had cached,
unflushed data yet so reopen had incorrect view of the file.

need to invalidate the cache even if the open didn't return a
different change attribute than the one stored in the fcb, unfortunately.
This commit is contained in:
Olga Kornievskaia 2012-05-10 14:57:12 -04:00
parent 69bb1094f9
commit 453c0cc875
1 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

18
sys/nfs41_driver.c
View file

@ -3805,16 +3805,24 @@ NTSTATUS nfs41_Create(
print_std_info(1, &nfs41_fcb->StandardInfo); print_std_info(1, &nfs41_fcb->StandardInfo);
#endif #endif
if (Fcb->OpenCount > 0 && /* aglo: 05/10/2012. it seems like always have to invalid the cache if the
nfs41_fcb->changeattr != entry->u.Open.changeattr && * file has been opened before and being opened again for data access.
* If the file was opened before, RDBSS might have cached (unflushed) data
* and by opening it again, we will not have the correct representation of
* the file size and data content. fileio tests 208, 219, 221.
*/
if (Fcb->OpenCount > 0 && (isDataAccess(params->DesiredAccess) ||
nfs41_fcb->changeattr != entry->u.Open.changeattr) &&
!nfs41_fcb->StandardInfo.Directory) { !nfs41_fcb->StandardInfo.Directory) {
ULONG flag = DISABLE_CACHING; ULONG flag = DISABLE_CACHING;
#ifdef DEBUG_OPEN #ifdef DEBUG_OPEN
DbgP("nfs41_Create: reopening (changed) file %wZ\n", SrvOpen->pAlreadyPrefixedName); DbgP("nfs41_Create: reopening (changed) file %wZ\n",
SrvOpen->pAlreadyPrefixedName);
#endif #endif
RxChangeBufferingState((PSRV_OPEN)SrvOpen, ULongToPtr(flag), 1); RxChangeBufferingState((PSRV_OPEN)SrvOpen, ULongToPtr(flag), 1);
} else if (!nfs41_fcb->StandardInfo.Directory && }
isDataAccess(params->DesiredAccess)) { if (!nfs41_fcb->StandardInfo.Directory &&
isDataAccess(params->DesiredAccess)) {
nfs41_fobx->deleg_type = entry->u.Open.deleg_type; nfs41_fobx->deleg_type = entry->u.Open.deleg_type;
#ifdef DEBUG_OPEN #ifdef DEBUG_OPEN
DbgP("nfs41_Create: received delegation %d\n", entry->u.Open.deleg_type); DbgP("nfs41_Create: received delegation %d\n", entry->u.Open.deleg_type);