evin/ms-nfs41-client
3
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

[setattr] uses memory out upcall buffer

Browse source
This commit is contained in:
Olga Kornievskaia 2011-09-16 17:05:57 -04:00
parent 3a115a39fa
commit 1c5935865b
1 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
daemon/setattr.c
View file

@ -49,13 +49,8 @@ static int parse_setattr(unsigned char *buffer, uint32_t length, nfs41_upcall *u
if (status) goto out; if (status) goto out;
status = safe_read(&buffer, &length, &args->buf_len, sizeof(args->buf_len)); status = safe_read(&buffer, &length, &args->buf_len, sizeof(args->buf_len));
if (status) goto out; if (status) goto out;
args->buf = malloc(args->buf_len);
if (args->buf == NULL) { args->buf = buffer;
status = GetLastError();
goto out;
}
status = safe_read(&buffer, &length, args->buf, args->buf_len);
if (status) goto out_free;
args->root = upcall->root_ref; args->root = upcall->root_ref;
args->state = upcall->state_ref; args->state = upcall->state_ref;
@ -63,9 +58,6 @@ static int parse_setattr(unsigned char *buffer, uint32_t length, nfs41_upcall *u
"buf_len=%d\n", args->path, args->set_class, args->buf_len); "buf_len=%d\n", args->path, args->set_class, args->buf_len);
out: out:
return status; return status;
out_free:
free(args->buf);
goto out;
} }
static int handle_nfs41_setattr(setattr_upcall_args *args) static int handle_nfs41_setattr(setattr_upcall_args *args)
@ -495,7 +487,6 @@ static int handle_setattr(nfs41_upcall *upcall)
break; break;
} }
free(args->buf);
return status; return status;
} }